Add HE2411 battery support #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
civerachb-cpr
requested review from
tonybaltovski and
luis-camero
and removed request for
a team
luis-camero
reviewed
Jan 13, 2025
There was a problem hiding this comment.
If the HE2411 is significantly different than the HE2613, a LUT should probably be added in a new class: https://github.com/clearpathrobotics/clearpath_robot/blob/humble/clearpath_hardware_interfaces/clearpath_hardware_interfaces/battery_state/battery.py#L244
Regardless, an entry should be added to point to the HE2613 battery class or to the new class: https://github.com/clearpathrobotics/clearpath_robot/blob/humble/clearpath_hardware_interfaces/clearpath_hardware_interfaces/battery_state/battery.py#L311
|
Waiting for the actual values, but opened a related MR at clearpathrobotics/clearpath_robot#119 to address the items above. Marking this MR as a draft until 119 is ready. |
luis-camero
approved these changes
Jan 13, 2025
tonybaltovski
approved these changes
Jan 14, 2025
civerachb-cpr
added a commit
that referenced
this pull request
Jan 14, 2025
* Add support for the HE2411 battery to J100 and A200 * Add the even-older HE2410 too
civerachb-cpr
added a commit
that referenced
this pull request
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves RPSW-2203
Should be cherry-picked into Jazzy once merged.